fix: enable datadog tracer #3431
Merged
+23
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sawadashota <shota@sslife.tech>
sawadashota
commented
Feb 5, 2023
| @@ -6,7 +6,7 @@ WORKDIR /go/src/github.com/ory/hydra | |||
| RUN mkdir -p ./internal/httpclient | |||
|
|
|||
| COPY go.mod go.sum ./ | |||
| COPY internal/httpclient/go.* ./internal/httpclient | |||
| COPY internal/httpclient/go.* ./internal/httpclient/ | |||
There was a problem hiding this comment.
Without a trailing slash, it will fail.
Step 6/21 : COPY internal/httpclient/go.* ./internal/httpclient
When using COPY with more than one source file, the destination must be a directory and end with a /
make: *** [docker] Error 1
|
Seems like tests are failing, can you PTAL? :) |
Codecov Report
@@ Coverage Diff @@
## master #3431 +/- ##
==========================================
+ Coverage 76.47% 76.74% +0.26%
==========================================
Files 123 123
Lines 10535 9022 -1513
==========================================
- Hits 8057 6924 -1133
+ Misses 1990 1657 -333
+ Partials 488 441 -47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@aeneasr I'm sorry, but I've fixed it! |
aeneasr
reviewed
Feb 6, 2023
This was referenced Feb 7, 2023
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load OpenTelemetry configuration to set up datadog tracer.
Related issue(s)
none
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments